Remove ice roads from Finland routing #5355
Conversation
There was a problem hiding this comment.
This is okay for me but I would encourage you to write a test with some examples.
The reason I'm saying this is that I did something similar in the HoustonMapper and I realised that other matches can "win" over yours.
For example if there is a matcher saying highway=residential;sidewalk=no it would win over your new ones because they describe a "better" match. I was very surprised by this.
This is not required for getting this merged.
|
Ok good point. I was also wondering if this should be put in the default mapper. The problem is same everywhere. We do not have many users in places where ice is permanent. And those few probably won't use journey planners. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5355 +/- ##
=============================================
+ Coverage 66.38% 66.44% +0.06%
- Complexity 15196 15211 +15
=============================================
Files 1786 1786
Lines 69232 69239 +7
Branches 7319 7311 -8
=============================================
+ Hits 45957 46005 +48
+ Misses 20799 20757 -42
- Partials 2476 2477 +1
☔ View full report in Codecov by Sentry. |
Summary
A simple filtering of ice and winter roads using Finland tag mapping. Ice roads are in use only some months per year, so they should be exluded from the street graph.
At later stage, we might consider implementing a configurable time period for such roads, or perhaps start supporting some OSM tags which limit the time period when the roads are available.